On 09/01/19(Wed) 19:12, Theo de Raadt wrote: > Philip Guenther <guent...@gmail.com> wrote: > > > On Wed, Jan 9, 2019 at 1:11 AM Klemens Nanni <k...@openbsd.org> wrote: > > > > > On Wed, Jan 09, 2019 at 01:12:31PM +1000, David Gwynne wrote: > > > > -#define TRUNK_MAX_STACKING 4 /* maximum number of stacked > > > trunks */ > > > Is this an arbitrary limit or does it conceal other limitiations? > > > > > > > If stacking is handled via possibly recursive calls then there's an > > effective limit imposed by size of the kernel stack. > > > > Imposing a depth limit also prevents looping a stack by adding an upper > > trunk to a bottom one. > > David please stack 100 times. > > Does it work?
I understand David. This logic is not coherent with the other pseudo-drivers and not limited to trunk(4). Could it be possible to move it out of trunk and turn it generic now that we have a common SIOCSIFPARENT ioctl(2)?
