Hi,
This code is buggy, since subtraction and then casting to int will not
produce the right result if the values are too far apart.
There must be more like this in the tree.... any volunteers?
In general, you don't want to do subtraction, even for ints. For
example: compare INT_MIN and 1. INT_MIN - 1 is a large positive
number. Sadly the internet is full of bad examples using subtraction.
-Otto
Index: optr.c
===================================================================
RCS file: /cvs/src/sbin/dump/optr.c,v
retrieving revision 1.39
diff -u -p -r1.39 optr.c
--- optr.c 12 Oct 2015 15:12:44 -0000 1.39
+++ optr.c 21 Jan 2019 19:45:24 -0000
@@ -423,6 +423,7 @@ datesort(const void *a1, const void *a2)
diff = strncmp(d1->dd_name, d2->dd_name, sizeof(d1->dd_name));
if (diff == 0)
- return (d2->dd_ddate - d1->dd_ddate);
+ return (d2->dd_ddate < d1->dd_ddate ? -1 :
+ (d2->dd_ddate > d1->dd_ddate ? 1 : 0));
return (diff);
}
