On Thu, Jan 24, 2019 at 04:35:02AM -0700, Theo de Raadt wrote: > just a comment: > > drivers with firmware have often had special parameters to the stop or > reset functions to indicate a difference between "stop moving traffic" > or "shut it all down". We seem to keep switching this back and forth. > Reason is we've had some very bizzare failure conditions in drivers, > in some cases even stop->firmware->restart ... RECURSION! It may not > be worth simply deleting this flag, unless it is sure this driver's > firmware-load / firmware-reset / "ifconfig down" / other behaviours > will never (including in future chip models) need it. Then this > flagging may simply have to be added back.
Interesting. It seems such issues didn't prevail after all? And yes, we can simply add it back when needed. By the way, the following files in dev/pci use this pattern: if_cas.c if_ipw.c if_iwi.c if_iwn.c if_nfe.c if_pcn.c if_stge.c if_wpi.c if_xge.c The 'disable' parameter only has an effect in pcn and stge where it controls draining of the Rx queue. It has no effect in any of the other drivers. Historical baggage?
