Diff reads good, although I'm not a BGP user.

One nit inline:

> @@ -689,31 +690,32 @@ mrt_parse_dump_mp(struct mrt_hdr *hdr, v

> -     case AF_VPNv4:
> +     case AID_VPN_IPv4:
>               if (len < MRT_PREFIX_LEN(r->prefixlen))
>                       goto fail;
> -             errx(1, "AF_VPNv4 handling not yet implemented");
> +             errx(1, "AID_VPN_IPv4 handling not yet implemented");
> +             goto fail;
> +     case AID_VPN_IPv6:
> +             if (len < MRT_PREFIX_LEN(r->prefixlen))
> +                     goto fail;
> +             errx(1, "AID_VPN_IPv6 handling not yet implemented");
>               goto fail;
These labels are unreachable after errx(3), so why add them?

Reply via email to