On Sat, Mar 09, 2019 at 08:50:10AM -0700, Theo de Raadt wrote:
> Otto Moerbeek <[email protected]> wrote:
>
> > On Sat, Mar 09, 2019 at 11:23:22AM +0100, Sebastian Benoit wrote:
> >
> > > We free a few strings in main(), some others we dont. We should either
> > > free() all strings consistently or not free them at all, because it does
> > > not
> > > hurt to keep them until exit().
> > >
> > > The chances of the main() function being repurposed and that leading to
> > > memleaks is slim, readability is more important here, so this diff removes
> > > the free() calls.
> > >
> > > ok?
> > >
> > > (acme_no_free_in_main.diff)
> >
> > remeber the malloc code does some consistentcy checks on free, so
> > this might cause misses of detection of memory management bugs,
>
> Yet such teardown strategies often add substantial complexity, and the
> complexity can hide other kinds of bugs.
Yes, it is a matter of good judgement.
-Otto
