On Mon, Apr 15, 2019 at 09:03:54PM +0200, Hiltjo Posthuma wrote:
> Hi,
>
> I noticed in the default config file /etc/X11/xenodm/Xresources
> there is a rule:
>
> xlogin*login.translations: #override \
> Ctrl<Key>R: abort-display()\n\
> [...]
>
> The xenodm(1) man page says:
> "
> abort-display
> Terminates the server, disabling it. This action is not
> accessible in the default configuration. There are
> various reasons to stop xenodm on a system console, such
> as when shutting the system down, when using xdmshell(1),
> to start another type of server, or to generally access
> the console. Sending xenodm a SIGHUP will restart the
> display. See the section CONTROLLING XENODM.
> "
>
> I think the man page means the action is not accessible in the default
> configuration if there is no Xresources file present.
>
> Currently in the default configuration a user can kill the xenodm service by
> pressing Ctrl-R. The user usually cannot restart the daemon themself (no
> privileges).
>
>
> Is this intended?
Not really. This has all been copied from xdm and never seriously
revisited. I think the best thing to do is to remove the resource to
match what the man page says.
And in the man page, the reference to xdmshell should be removed.
Ok for the patch below ?
Index: config/Xresources.in
===================================================================
RCS file: /cvs/OpenBSD/xenocara/app/xenodm/config/Xresources.in,v
retrieving revision 1.1
diff -u -r1.1 Xresources.in
--- config/Xresources.in 26 Jul 2017 21:14:54 -0000 1.1
+++ config/Xresources.in 15 Apr 2019 19:10:51 -0000
@@ -9,7 +9,6 @@
xlogin*login.translations: #override \
- Ctrl<Key>R: abort-display()\n\
<Key>F1: set-session-argument(failsafe) finish-field()\n\
<Key>Left: move-backward-character()\n\
<Key>Right: move-forward-character()\n\
Index: man/xenodm.man
===================================================================
RCS file: /cvs/OpenBSD/xenocara/app/xenodm/man/xenodm.man,v
retrieving revision 1.9
diff -u -r1.9 xenodm.man
--- man/xenodm.man 11 Jul 2018 16:28:54 -0000 1.9
+++ man/xenodm.man 15 Apr 2019 19:10:51 -0000
@@ -683,7 +683,6 @@
it usually contains parameters for that widget:
.Bd -literal -offset Ds
xlogin*login.translations: #override\e
- Ctrl<Key>R: abort-display()\en\e
<Key>F1: set-session-argument(failsafe) finish-field()\en\e
<Key>Return: set-session-argument() finish-field()
xlogin*borderWidth: 3
@@ -975,9 +974,8 @@
This action is not accessible in the default configuration.
There are various reasons to stop
.Nm
-on a system console, such as when shutting the system down, when using
-.Xr xdmshell 1 ,
-to start another type of server, or to generally access the console.
+on a system console, such as when shutting the system down,
+or to generally access the console.
Sending
.Nm
a
--
Matthieu Herrb
