Hi all,

I have one question about *relayd*.

FILE: /usr.sbin/relayd/check_script.c

    In function 'script_sig_alarm(int sig)':

** A function parameter ( sig ) is not used in the body of the function.

** I think, that If the argument is needed for type compatibility or future plans, we have to use /*@unused@*/ in the argument declaration.

** If I am correct, please approve my patch. If not, sorry for interrupt. Please ignore it.

P.S. Sorry for my English, and C Programming skills.

BR,

Oleg Pahl
Index: check_script.c
===================================================================
RCS file: /cvs/src/usr.sbin/relayd/check_script.c,v
retrieving revision 1.21
diff -u -p -u -p -r1.21 check_script.c
--- check_script.c      28 May 2017 10:39:15 -0000      1.21
+++ check_script.c      23 Apr 2019 22:32:15 -0000
@@ -76,7 +76,7 @@ script_done(struct relayd *env, struct c
 }
 
 void
-script_sig_alarm(int sig)
+script_sig_alarm(int)
 {
        int save_errno = errno;
 

Reply via email to