On Mon, Apr 29, 2019 at 08:55:40PM +0200, Alexandr Nedvedicky wrote:
> > > @@ -1165,6 +1168,11 @@ and
> > > These keywords correspond to the similar (LOG_) values specified to the
> > > .Xr syslog 3
> > > library routine.
> > > +The default value is
> > > +.Cm err .
> > > +.Xr pfctl 8
> > > +.Fl F Cm Reset
> > > +restores customized value back to default.
> >
> > i want to be sure this text is grammatically correct. does Reset work on
> > a number of changed settings at once? if so, then "restores customized
> > values back to their defaults" or sth like that.
>
> in case of 'set debug' option the paragraph talks single option, which can
> be set to 7 (or so) different values. hence I'm using single instead of
> plural. I'm keeping my version, just let me know if I should change it.
>
ah, so singular is correct. but it needs an article of some sort. how
about:
.Xr pfctl 8
.Fl F Cm Reset
restores this value to its default.
to be honest, i don;t like it when we Xr like this, or mark up so much.
i would go for
.Dq pfctl -F Reset
restores this value to its default.
or .Li instead of .Dq maybe
> >
> > > +.Xr pfctl 8
> > > +.Fl F Cm Reset
> > > +restores customized settings back to default.
> > > +.sp
> >
> > what's the .sp for? if you want vertical blank space, use .Pp
>
> I think it was suggested by 'mandoc -T lint', I've removed
> that and lint seems to be still OK.
>
ok, .sp, which i always forget about, is basically roff for .Pp. just
use .Pp if you need the vertical spacing.
>
> </snip>
> > > (tcp.first 60, tcp.established 43200).
> > > +.Pp
> > > +.Xr pfctl 8
> > > +.Fl F Cm Reset
> > > +restores customized any timeout setting back to default.
> >
> > this reads weird!
> >
>
> I've fixed that to:
>
> restores any customized timeout setting back to default.
>
maybe
restores this setting to its default value.
>
> thank you for helping me to get my changes to shape. I'll chase some PF
> folks for OKs next week.
>
cool, thanks for working on this.
jmc
