On Sun, Jun 9, 2019 at 10:39 PM Theo de Raadt <dera...@openbsd.org> wrote:
>
> Amit Kulkarni <amit.o...@gmail.com> wrote:
>
> > > Index: sys/sysctl.h
> > > ===================================================================
> > > RCS file: /cvs/src/sys/sys/sysctl.h,v
> > > retrieving revision 1.188
> > > diff -u -p -r1.188 sysctl.h
> > > --- sys/sysctl.h 1 Jun 2019 14:11:18 -0000 1.188
> > > +++ sys/sysctl.h 1 Jun 2019 16:36:13 -0000
> > > @@ -629,7 +629,7 @@ do {
> > > \
> > > (kp)->p_stat = (p)->p_stat; \
> > > (kp)->p_slptime = (p)->p_slptime; \
> > > (kp)->p_holdcnt = 1; \
> > > - (kp)->p_priority = (p)->p_priority; \
> > > + (kp)->p_priority = (p)->p_usrpri + PZERO; \
> > > (kp)->p_usrpri = (p)->p_usrpri; \
> > > if ((p)->p_wchan && (p)->p_wmesg) \
> > > copy_str((kp)->p_wmesg, (p)->p_wmesg, \
> > >
> >
> >
> > Hi,
> >
> > A request, to remove the +PZERO here above and the -PZERO in
> > /usr/src/usr.bin/top/machine.c, why do an unnecessary calculation twice,
> > once to set and other time to this?
>
> This is getting out of hand.
>
> Have you reviewed the *entire universe* of software to ensure that
> top is the only program which looks at this?
>
> No. You have not. So please stop proposing changes where you aren't
> willing to invest into studying the history.
Got it. Sorry, my fault here.
