Re: pflog(4) free sizes

[Martin Pieuchot]

On 10/06/19(Mon) 19:04, Klemens Nanni wrote:
> On Mon, Jun 10, 2019 at 01:55:29PM -0300, Martin Pieuchot wrote:
> > ok?
> OK kn
> 
> There's another in `pflog_clone_destroy()'.

Updated diff including your suggestions.

Index: net/if_pflog.c
===================================================================
RCS file: /cvs/src/sys/net/if_pflog.c,v
retrieving revision 1.82
diff -u -p -r1.82 if_pflog.c
--- net/if_pflog.c      10 Dec 2018 16:48:15 -0000      1.82
+++ net/if_pflog.c      11 Jun 2019 15:07:38 -0000
@@ -124,8 +124,7 @@ pflogifs_resize(size_t n)
                else
                        p[i] = NULL;
 
-       if (pflogifs)
-               free(pflogifs, M_DEVBUF, 0);
+       free(pflogifs, M_DEVBUF, npflogifs * sizeof(*pflogifs));
        pflogifs = p;
        npflogifs = n;
        return (0);
@@ -183,7 +182,7 @@ pflog_clone_destroy(struct ifnet *ifp)
        NET_UNLOCK();
 
        if_detach(ifp);
-       free(pflogif, M_DEVBUF, 0);
+       free(pflogif, M_DEVBUF, sizeof(*pflogif));
        return (0);
 }