On Fri, Jun 21, 2019 at 05:08:15PM -0300, Martin Pieuchot wrote:
> ok?
OK, one comment inline.
> Index: net/radix.c
> ===================================================================
> RCS file: /cvs/src/sys/net/radix.c,v
> retrieving revision 1.58
> diff -u -p -r1.58 radix.c
> --- net/radix.c 20 Jun 2017 09:03:39 -0000 1.58
> +++ net/radix.c 21 Jun 2019 20:00:44 -0000
> @@ -457,7 +457,7 @@ rn_addmask(void *n_arg, int search, int
> tm = rn_insert(cp, mask_rnhead, &maskduplicated, tm);
> if (maskduplicated) {
> log(LOG_ERR, "%s: mask impossibly already in tree\n", __func__);
> - free(saved_tm, M_RTABLE, 0);
> + free(saved_tm, M_RTABLE, max_keylen + 2 * sizeof (*tm));
Although the same due to `saved_tm = tm', using `saved_tm' here ^ is
more consistent and obvious on its own.
> return (tm);
> }
> /*
