I will continue to argue that testing out-of-the-tree is wrong, and instead the regression tests should test the installed binaries.
Less than 10 regression tests are going this way. I think it is a problematic fad. Moritz Buhl <[email protected]> wrote: > Hi, > I noticed that the iked regress test fails if I have an obj directory. > The following patch adresses this. > > mbuhl > > Index: regress/sbin/iked/parser/Makefile > =================================================================== > RCS file: /mount/openbsd/cvs//src/regress/sbin/iked/parser/Makefile,v > retrieving revision 1.2 > diff -u -p -r1.2 Makefile > --- regress/sbin/iked/parser/Makefile 30 May 2017 15:36:13 -0000 1.2 > +++ regress/sbin/iked/parser/Makefile 21 Jun 2019 02:06:02 -0000 > @@ -17,7 +17,7 @@ test_parser: ${IKEOBJS} > > ${IKEOBJS}: > cd ${.CURDIR}/../../../../sbin/iked && make $@ > - ln -sf ${.OBJDIR}/../../../../sbin/iked/$@ . > + ln -sf ${.CURDIR}/../../../../sbin/iked/$@ . > > LDADD+= -L${.OBJDIR} -ltest_helper > DPADD+= libtest_helper.a >
