28 août 2019 15:10 "Martijn van Duren" <[email protected]> a écrit:
> On 8/28/19 2:52 PM, [email protected] wrote: > >> Yes sorry my bad, but this still covers the textstring argument: >> >> We need to be able to reject at banner and this is going to be implemented >> as a filter phase, so basically if we expect people to need it for filters >> the proper place to pass your textstring to filters is in that filter phase. > > I'll commit it without the textstring. > ok ! > I just don't understand what you mean by reject at banner. > We only allow filtering on smtp-in and since we are the once that > produce the banner, how will you filter at that point? I still haven't fully gone through this but the bottom line is: - today we have report link-connect and we have filter phase connect - link-connect makes sense in getting info from the connection to build session, this is good - filter phase connect is kinda of weird as it gets the same info as the previous report event which is not right and it answers results in the banner displayed, it's kind of a strange filter phase in my opinion I think the filter phase connect should really be a filter phase "greeting" and this would get the session id to retrieve session state accumulated from report link-connect, as well as the banner as input, resulting in a proceed, rewrite, reject or disconnect action. It would make more sense but i haven't gone completely through this to make sure its correct, I'll make a proposal soon.
