On Mon, Nov 11, 2019 at 06:33:39PM +0200, Stefan Sperling wrote: > > On Mon, Nov 11, 2019 at 10:19:12AM +0800, Kevin Lo wrote: > > On Sat, Nov 09, 2019 at 01:01:39PM +0200, Stefan Sperling wrote: > > > > > > This diff makes 3168 devices actually work with iwm(4). > > > These devices have never worked right since the driver just threw > > > errors when trying to load firmware. > > > > Indeed. The 3168 device didn't work for me (for example, ifconfig iwm0 scan > > returns empty results) until your diff is applied. > > The previous diff broke 7260/7265 devices. I made a mistake which resulted > in channel data structures not being initialized on those devices which > resulted in "panic: iwm0: bogus channel pointer" during boot. > > Problem fixed with the diff below.
This diff still works on my msi Cubi 3 Silent. > ok? ok kevlo@
