On Tue, 12 Nov 2019 at 16:08, Tobias Heider <tobias.hei...@stusta.de> wrote:
> On Tue, Nov 12, 2019 at 09:57:31AM +0100, Mike Belopuhov wrote: > > Hi Tobias, > > > > I see, however, I don't think iked would negotiate an SA > > without ESN support if the other side supports ESN, so I'm > > not sure how "enforcing" changes that. > > It doesn't, but if I have an iked on both sides one will have to > make the decision. I have another case where I actually can not > use ESN, with two ikeds this can not be configured currently. > > > In any case, I'm not opposed to adding a toggle if you guys > > need it, but could you please adjust the grammar so that "esn" > > and "no esn" are used instead of "on" and "off" since that's > > what we're normally doing. "on" and "off" are clutches for > > simple file formats, parse.y allows you to make it a bit nicer. > > Makes sense. Here is the updated diff including a fix for bluhms > comment. > > While I meant "no esn" with a space, I see that you and Patrick have been adding things like "nofragmentation" and "nomobike". These should be written with a space as well. Nevertheless ok mikeb, hopefully you'll come around fixing grammar later on.
