My emails are getting delayed, I sent another one with unveil(NULL, NULL) right afterwards :)
On 10:05 Fri 29 Nov , Theo de Raadt wrote: > Klemens Nanni <[email protected]> wrote: > > > On Fri, Nov 29, 2019 at 03:01:45PM +0000, Ricardo Mestre wrote: > > > All combination of parameters were tested, comments, OK? > > OK kn > > > > > Index: pcidump.c > > > =================================================================== > > > RCS file: /cvs/src/usr.sbin/pcidump/pcidump.c,v > > > retrieving revision 1.55 > > > diff -u -p -u -r1.55 pcidump.c > > > --- pcidump.c 28 Jun 2019 13:32:49 -0000 1.55 > > > +++ pcidump.c 29 Nov 2019 14:54:32 -0000 > > > @@ -188,6 +188,9 @@ main(int argc, char *argv[]) > > > err(1, "%s", romfile); > > > } > > > > > > + if (unveil("/dev", "r") == -1) > > > + err(1, "unveil"); > > > + > > There is no pledge call afterwards, so this unveil should be finalised. > > needs a unveil(NULL, NULL) > > pledge will not work. The code is full of ioctl. > > > > > > if (hex > 1) > > > size = 256; > > > if (hex > 2) > > > > >
