On Tue, Jan 07, 2020 at 06:42:08PM +0100, Dariusz Sendkowski wrote:
> Hi,
> 
> I've bought a new SSD drive by ADATA recently and its vendor and product
> IDs are missing in pcidevs. Here is a patch to add it to the pcidevs.
> 
> Vendor and product info is taken from:
> https://devicehunt.com/view/type/pci/vendor/1CC1/device/8201
> 

The official place for vendor ids is
https://pcisig.com/membership/member-companies?combine=1cc1

> 
> Index: pcidevs
> ===================================================================
> RCS file: /cvs/src/sys/dev/pci/pcidevs,v
> retrieving revision 1.1911
> diff -u -p -u -p -r1.1911 pcidevs
> --- pcidevs 5 Jan 2020 12:54:21 -0000 1.1911
> +++ pcidevs 7 Jan 2020 17:23:14 -0000
> @@ -336,6 +336,7 @@ vendor ETRON 0x1b6f Etron
>  vendor FRESCO 0x1b73 Fresco Logic
>  vendor WCH2 0x1c00 Nanjing QinHeng Electronics
>  vendor SYMPHONY2 0x1c1c Symphony Labs
> +vendor ADATA 0x1cc1 ADATA Technology
>  vendor UMIS 0x1cc4 Union Memory
>  vendor ROCKCHIP 0x1d87 Rockchip
>  vendor TEKRAM2 0x1de1 Tekram
> @@ -7834,6 +7835,9 @@ product UMC UM9017F 0x9017 UM9017F
>  product UMC UM8886E_OR_WHAT 0xe886 ISA
>  product UMC UM8886N 0xe88a UM8886N
>  product UMC UM8891N 0xe891 UM8891N
> +
> +/* ADATA products */
> +product ADATA SX8200_NVME 0x8201 XPG SX8200 Pro PCIe Gen3x4 SSD

Your patch mangles whitespace and does not correctly order the ADATA
products.

Index: pcidevs
===================================================================
RCS file: /cvs/src/sys/dev/pci/pcidevs,v
retrieving revision 1.1911
diff -u -p -r1.1911 pcidevs
--- pcidevs     5 Jan 2020 12:54:21 -0000       1.1911
+++ pcidevs     7 Jan 2020 23:53:51 -0000
@@ -336,6 +336,7 @@ vendor      ETRON           0x1b6f  Etron
 vendor FRESCO          0x1b73  Fresco Logic
 vendor WCH2            0x1c00  Nanjing QinHeng Electronics
 vendor SYMPHONY2       0x1c1c  Symphony Labs
+vendor ADATA           0x1cc1  ADATA Technology
 vendor UMIS            0x1cc4  Union Memory
 vendor ROCKCHIP        0x1d87  Rockchip
 vendor TEKRAM2         0x1de1  Tekram
@@ -505,6 +506,9 @@ product ACER M1435          0x1435  M1435 VL-PCI
 product AD SP21535             0x1535  ADSP 21535 DSP
 product AD 1889                        0x1889  AD1889 Audio
 product AD SP2141              0x2f44  SafeNet ADSP 2141
+
+/* ADATA products */
+product ADATA SX8200           0x8201  SX8200
 
 /* Addtron products */
 product ADDTRON RHINEII                0x1320  RhineII

Reply via email to