On Sat, Jan 04, 2020 at 11:34:45PM +0100, Denis Fondras wrote:
> On Sat, Jan 04, 2020 at 11:11:36PM +0100, Remi Locherer wrote:
> > Hi,
> > 
> > interface-specific parameters can be defined globally or per area.
> > But they are applied to the interfaces only if the interfaces are
> > declared afterwards.
> > 
> 
> I have a diff to allow parameters after interface or area definition.
> Not sure if we want to do that though.

I would appreciate that! ;-)

> > Or is the GLOBAL CONFIURATION section the better place for this?
> > I opted for the AREA section because I consider it unlikely a user adds
> > global parameters at the end of the config file. But who knows. ;-)
> > 
> 
> In the MACRO section I would change the last sentence too (or even remove it 
> as
> it is close to the GLOBAL first paragraph).

True, it does not add a lot of value. But I don't have a strong opinion.

> 
> Anyway OK denis@
> 
> > Remi
> > 
> > Index: ospfd/ospfd.conf.5
> > ===================================================================
> > RCS file: /cvs/src/usr.sbin/ospfd/ospfd.conf.5,v
> > retrieving revision 1.58
> > diff -u -p -r1.58 ospfd.conf.5
> > --- ospfd/ospfd.conf.5      19 Nov 2019 09:55:55 -0000      1.58
> > +++ ospfd/ospfd.conf.5      4 Jan 2020 21:48:00 -0000
> > @@ -256,11 +256,13 @@ is set to a value other than 1 or if the
> >  Areas are used for grouping interfaces.
> >  All interface-specific parameters can
> >  be configured per area, overruling the global settings.
> > +These interface-specific parameters need to be defined before the 
> > interfaces.
> >  .Bl -tag -width Ds
> >  .It Ic area Ar id | address
> >  Specify an area section, grouping one or more interfaces.
> >  .Bd -literal -offset indent
> >  area 0.0.0.0 {
> > +   hello-interval 3
> >     interface em0
> >     interface em1 {
> >             metric 10
> > Index: ospf6d/ospf6d.conf.5
> > ===================================================================
> > RCS file: /cvs/src/usr.sbin/ospf6d/ospf6d.conf.5,v
> > retrieving revision 1.20
> > diff -u -p -r1.20 ospf6d.conf.5
> > --- ospf6d/ospf6d.conf.5    26 Dec 2019 10:24:18 -0000      1.20
> > +++ ospf6d/ospf6d.conf.5    4 Jan 2020 21:48:30 -0000
> > @@ -236,11 +236,13 @@ is set to a value different to 1 or if t
> >  Areas are used for grouping interfaces.
> >  All interface-specific parameters can
> >  be configured per area, overruling the global settings.
> > +These interface-specific parameters need to be defined before the 
> > interfaces.
> >  .Bl -tag -width Ds
> >  .It Ic area Ar address Ns | Ns Ar id
> >  Specify an area section, grouping one or more interfaces.
> >  .Bd -literal -offset indent
> >  area 0.0.0.0 {
> > +   hello-interval 3
> >     interface em0
> >     interface em1 {
> >             metric 10
> > 
> 

Reply via email to