On Wed, Jan 08, 2020 at 06:51:26PM +0100, Hrvoje Popovski wrote:
> Hi all,
> 
> in attachment you can find diff with some new AMD devices found in Dell
> R7515.
> 
> pcidevs are from
> https://raw.githubusercontent.com/pciutils/pciids/master/pci.ids
> 
> and usbdevs are from
> https://usb-ids.gowdy.us/read/UD/1604/10c0
> https://certification.ubuntu.com/catalog/component/1604:10c0
> 
> names for amd devices from 0x1490 to 0x1497 are little to general :)

Every pci device has a function, what class do they have?
see pcidump -v

> dmesg with this diff

> "AMD 17h/3xh PCIE" rev 0x00 at pci2 dev 0 function 0 not configured
> "AMD 17h/3xh PCIE" rev 0x00 at pci9 dev 0 function 0 not configured
> "AMD 17h/3xh PCIE" rev 0x00 at pci16 dev 0 function 0 not configured
> "AMD 17h/3xh PCIE" rev 0x00 at pci28 dev 0 function 0 not configured

whatever this id is looks to be wrong

> Index: pci/pcidevs
> ===================================================================
> RCS file: /home/cvs/src/sys/dev/pci/pcidevs,v
> retrieving revision 1.1911
> diff -u -p -r1.1911 pcidevs
> --- pci/pcidevs       5 Jan 2020 12:54:21 -0000       1.1911
> +++ pci/pcidevs       8 Jan 2020 17:17:22 -0000
> @@ -272,6 +272,7 @@ vendor    TOPIC           0x151f  Topic/SmartLink
>  vendor       ENE             0x1524  ENE
>  vendor       ARALION         0x1538  Aralion
>  vendor       TERRATEC        0x153b  TerraTec
> +vendor       PLDA            0x1556  PLDA
>  vendor       PERLE           0x155f  Perle
>  vendor       SYMBOL          0x1562  Symbol
>  vendor       SYBA            0x1592  Syba
> @@ -736,7 +737,23 @@ product AMD 17_CCP_2             0x1468  17h Crypto
>  product AMD 17_PCIE_4                0x1470  17h PCIE
>  product AMD 17_PCIE_5                0x1471  17h PCIE
>  product AMD 17_3X_RC         0x1480  17h/3xh Root Complex
> +product AMD 17_3X_IOMM               0x1481  17h/3xh IOMMU

might as well have IOMMU in the define

> +product AMD 17_3X_PCIE_1     0x1482  17h/3xh PCIE
> +product AMD 17_3X_PCIE_2     0x1483  17h/3xh PCIE
> +product AMD 17_3X_PCIE_3     0x1484  17h/3xh PCIE
> +product AMD 17_3X_SPP                0x1485  17h/3xh Reserved SPP

17h/3xh SPP

>  product AMD 17_3X_CCP                0x1486  17h/3xh Crypto
> +product AMD 17_3X_PCIE_4     0x148a  17h/3xh PCIE
> +product AMD 17_3X_XHCI_1     0x148c  17h/3xh xHCI
> +product AMD 17_3X_F_1                0x1490  17h/3xh Function
> +product AMD 17_3X_F_2                0x1491  17h/3xh Function
> +product AMD 17_3X_F_3                0x1492  17h/3xh Function
> +product AMD 17_3X_F_4                0x1493  17h/3xh Function
> +product AMD 17_3X_F_5                0x1494  17h/3xh Function
> +product AMD 17_3X_F_6                0x1495  17h/3xh Function
> +product AMD 17_3X_F_7                0x1496  17h/3xh Function
> +product AMD 17_3X_F_8                0x1497  17h/3xh Function
> +product AMD 17_3X_PTDMA              0x1498  17h/3xh Passthrough DMA Engine

17h/3xh DMA

>  product AMD 14_HB            0x1510  14h Host
>  product AMD 14_PCIE_1                0x1512  14h PCIE
>  product AMD 14_PCIE_2                0x1513  14h PCIE
> @@ -5866,6 +5883,7 @@ product MATROX G200EV           0x0530  MGA G200eV
>  product MATROX G200EW                0x0532  MGA G200eW
>  product MATROX G200EH                0x0533  MGA G200eH
>  product MATROX G200ER                0x0534  MGA G200eR
> +product MATROX G200EW3               0x0536  MGA G200eW3
>  product MATROX IMPRESSION    0x0d10  MGA Impression
>  product MATROX PRODUCTIVA_PCI        0x1000  MGA G100 PCI
>  product MATROX PRODUCTIVA_AGP        0x1001  MGA G100 AGP
> @@ -6830,6 +6848,9 @@ product PLANEX FNW_3800_TX      0xab07  FNW-38
>  
>  /* Platform */
>  product PLATFORM ES1849              0x0100  ES1849
> +
> +/* PLDA */
> +product      PLDA PCIE               0xbe00  PCI Express Bridge              

whitespace is wrong, string could be shorter

product PLDA PPB                0xbe00  PCIE

>  
>  /* PLX products */
>  product PLX 1076             0x1076  I/O 1076

> Index: usb/usbdevs
> ===================================================================
> RCS file: /home/cvs/src/sys/dev/usb/usbdevs,v
> retrieving revision 1.707
> diff -u -p -r1.707 usbdevs
> --- usb/usbdevs       5 Jan 2020 10:13:14 -0000       1.707
> +++ usb/usbdevs       8 Jan 2020 14:08:31 -0000
> @@ -548,6 +548,7 @@ vendor OLIMEX             0x15ba  Olimex
>  vendor AMIT2         0x15c5  AMIT
>  vendor TRUST         0x15d9  Trust
>  vendor SOHOWARE              0x15e8  SOHOware
> +vendor TASCAM                0x1604  Tascam

usb.org has 0x1604/5636 as "Kyokko Seiko"

https://www.usb.org/sites/default/files/vendor_ids082119_0.pdf

>  vendor UMAX          0x1606  UMAX Data Systems
>  vendor INSIDEOUT     0x1608  Inside Out Networks
>  vendor GOODWAY               0x1631  Good Way Technology
> @@ -4178,6 +4179,9 @@ product TANGTOP USBPS2          0x0001  USBPS2
>  
>  /* Tapwave products */
>  product TAPWAVE ZODIAC               0x0100  Zodiac
> +
> +/* Tascam */  
> +product TASCAM USB_DELL_HUB  0x10c0  Dell Integrated Hub

"Dell" and "Integrated" not needed

Does the hub not have a string normally?

Reply via email to