On Sun, Jan 12, 2020 at 01:33:43PM +0100, Martin Pieuchot wrote:
> @@ -304,7 +306,7 @@ soclose(struct socket *so, int flags)
> while (so->so_state & SS_ISCONNECTED) {
> error = sosleep(so, &so->so_timeo,
> PSOCK | PCATCH, "netcls",
> - so->so_linger * hz);
> + SEC_TO_NSEC(so->so_linger));
> if (error)
> break;
> }
In sosleep() the sleep forever semantics has been converted from 0
to INFSLP. We have to pay attention at every caller.
> @@ -333,11 +333,11 @@ nfs_connect(struct nfsmount *nmp, struct
In this function is a call that has been forgotten in the conversion.
sosleep(so, &so->so_timeo, PSOCK, "nfscon", 2 * hz);
Should we rename sosleep() to sosleep_nsec() and force to have all
the critical places in the diff? Its semantics has changed, maybe
we should change the name.
bluhm
