On Tue, Jan 21, 2020 at 01:09:30PM +0100, Denis Fondras wrote:
> On Tue, Jan 21, 2020 at 09:35:06AM +0100, Remi Locherer wrote:
> > > @@ -235,6 +233,7 @@ lsa_check(struct rde_nbr *nbr, struct ls
> > >   case LSA_TYPE_NETWORK:
> > >           if ((len % sizeof(u_int32_t)) ||
> > >               len < sizeof(lsa->hdr) + sizeof(u_int32_t)) {
> > > +                 log_warnx("lsa_check: bad LSA network packet");
> > 
> > please use __func__
> > 
> 
> None use __func__ currently.
> 

Right, it's not often used in ospf6d.

I think we should use it more in such cases.

But you have my OK with or without that.

Remi

Reply via email to