On Fri, Jan 31 2020, Ingo Schwarze <schwa...@usta.de> wrote: > Hi, > > ngc...@gmail.com wrote on Fri, Jan 31, 2020 at 10:14:52PM +0900: > >> Reduce scope of a few variables. > > No, this contradicts OpenBSD coding style. > We want local variables declared up front in functions > such that you can see at one glance which variables exist.
Huh, this is your personal preference and I strongly disagree with making it an "official" stance (again). Reducing the scope of variables *quite often* helps reasoning about them. style(9) said something like that, and has been changed three years ago (for good IMO). revision 1.68 date: 2016/10/18 18:13:56; author: millert; state: Exp; lines: +2 -4; commitid: aPPHgmmA4hseZUFx; Don't tell the programmer not to put variable declarations inside blocks. OK guenther@ kettenis@ This being said, the patch doesn't apply and the proposed change doesn't improve the current code much, so this feels like needless churn. "ngc891", please find another itch to scratch. :) >> While here, remove an extraneous space. > > While avoiding trailing whitespace is good, it's not worth > a commit (nor sending patches around). Seconded. -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
