On Sun, Feb 02, 2020 at 01:50:58PM +0000, Andrew Grillet wrote:
> I have used the mac-addr feature (for netboot reasons). I think this
> probably caused me grief
> but I assumed I was at fault and did not bother reporting it.
Please consider to do so in the future.

> I prefer same line, no curly braces, and accurate documentation. And also
> error messages
> that are more explicit:
> Vnet.conf:4 Syntax error - Unexpected  "{" found.
Same or new line makes no difference, but curly braces is what all other
parsers I can find in base do.  They support lines with mutliple space
delimited keywords (most of them can be specified multiple times), but
once unique options are specified (such as a MAC address), those are
usually enclosed in their own semantic block.

It seems off to break with what vm.conf(5) already does here, so I'll
probably wip up a diff to make the following work:

        domain guest {
                vnet
                vnet { mtu=1500 }
                vnet {
                        mac-addr=00:11:...
                }
                ...
        }

Reply via email to