On Mon, Mar 16, 2020 at 10:16:34AM +0100, Patrick Wildt wrote: > On Sat, Mar 14, 2020 at 04:28:26AM +0100, Alexandre Ratchov wrote: > > On ASUS 1001PXD, _BQC returns an out of range value which makes > > acpivout_get_brightness() return -1, in turn breaking the > > display.brightness control (wsconsctl displays a mangled value). > > > > This diff ignores the out of range value and makes the brighness > > control just work again. > > > > OK? > > With the current code _BQC is only called on attach, where we > probably want a value higher than the lowest one. I wonder if > maybe we should move this check into the attach functions, and > in case of an error like this, set a reasonable brightness?
Just to be sure that I understand, do you suggest to change the brightness at attach time?
