On 19/03/20(Thu) 17:43, Klemens Nanni wrote:
> Index: bt.5
> ===================================================================
> RCS file: /cvs/src/usr.sbin/btrace/bt.5,v
> retrieving revision 1.3
> diff -u -p -r1.3 bt.5
> --- bt.5 18 Mar 2020 20:19:42 -0000 1.3
> +++ bt.5 19 Mar 2020 16:41:46 -0000
> @@ -107,10 +107,17 @@ of the corresponding probe
> .Pp
> Functions:
> .Pp
> -.Bl -tag -width "printf fmt ... " -compact
> +.Bl -tag -width "delete(@map[key])" -compact
> .It Fn clear "@map"
> Delete all (key, value) pairs from map
> .Va @map
> +.It Fn delete "@map[key]"
> +Delete the key
> +.Va key
> +from map
> +.Va @map
A map contains (key, value) pairs. In that sense delete() deletes a
pair. What about:
Delete the pair indexed by `key'.
> +.It Fn exit
> +Terminate with exit code 0
I don't see the value of mentioning the exit code. What about:
Terminate the execution.
> .It Fn print "@map"
> Print all (key, value) pairs from map
> .Va @map
> @@ -120,6 +127,9 @@ print formatted string
> .It Fn time timefmt
> print timestamps using
> .Xr strftime 3
> +.It Fn zero "@map"
> +Set values to 0 for all keys from map
> +.Va @map
Set all values of/from @map to 0?
While here what do you think about replacing 'from map @map' by 'from
@map' in clear() and print(). Since the manual is mentioning pairs
already this now seems redundant to me.
Thanks,
Martin
