Hi, I have 2 questions. In GostR3410_512_params[], "A" and "TCA" have the same NID, "B" and "TCB" too. I thought these were redundant, but are there any reasons for this ?
In GostR3410_512_params[], don't you need the record for NID_id_tc26_gost_3410_12_512_paramSetTest ? Best regards, On Sat, Mar 28, 2020 at 07:16:14PM +0300, Dmitry Baryshkov wrote: > Allow users to specify new curves via strings. > > Sponsored by ROSA Linux > > Signed-off-by: Dmitry Baryshkov <[email protected]> > --- > src/lib/libcrypto/gost/gostr341001_params.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/src/lib/libcrypto/gost/gostr341001_params.c > b/src/lib/libcrypto/gost/gostr341001_params.c > index 13054cd0fc26..0f068d97eb0a 100644 > --- a/src/lib/libcrypto/gost/gostr341001_params.c > +++ b/src/lib/libcrypto/gost/gostr341001_params.c > @@ -94,12 +94,19 @@ static const GostR3410_params GostR3410_256_params[] = { > { "0", NID_id_GostR3410_2001_TestParamSet }, > { "XA", NID_id_GostR3410_2001_CryptoPro_XchA_ParamSet }, > { "XB", NID_id_GostR3410_2001_CryptoPro_XchB_ParamSet }, > + { "TCA", NID_id_tc26_gost_3410_12_256_paramSetA }, > + { "TCB", NID_id_tc26_gost_3410_12_256_paramSetB }, > + { "TCC", NID_id_tc26_gost_3410_12_256_paramSetC }, > + { "TCD", NID_id_tc26_gost_3410_12_256_paramSetD }, > { NULL, NID_undef }, > }; > > static const GostR3410_params GostR3410_512_params[] = { > { "A", NID_id_tc26_gost_3410_12_512_paramSetA }, > { "B", NID_id_tc26_gost_3410_12_512_paramSetB }, > + { "TCA", NID_id_tc26_gost_3410_12_512_paramSetA }, > + { "TCB", NID_id_tc26_gost_3410_12_512_paramSetB }, > + { "TCC", NID_id_tc26_gost_3410_12_512_paramSetC }, > { NULL, NID_undef }, > }; > > -- > 2.25.1 >
