Hi Martin, Martin wrote on Sun, Mar 29, 2020 at 10:22:15PM +0200:
> It seems these are just a coded form for no return value, > unless this is some libssl slang I am not aware of. I don't think "does not provide diagnostic information" has any special meaning in libssl. Also, the word "diagnostic" doesn't appear anywhere else in the libssl manuals (well, except for a weird BUGS entry in SSL_CTX_set_cert_verify_callback(3)). I checked the source code. Among these functions, SSL_free(3) is the only one doing substantial amounts of non-trivial work. It is possible that something in there might sometimes call ERR_put_error(3). But even if so, the sentence deleted claimed the opposite, if interpreted as talking about the error stack. Either way, saying that something does *not* call ERR_put_error(3) isn't useful even when it happens to be true. The other functions touched here clearly cannot fail, do no error handling, and don't need any such remark. So yes, i think this was merely a very confusing way to express the statement "these are void function". Consequently, i committed your patch. Thanks, Ingo > Index: SSL_CTX_set_client_CA_list.3 > =================================================================== > RCS file: /cvs/src/lib/libssl/man/SSL_CTX_set_client_CA_list.3,v > retrieving revision 1.5 > diff -u -p -r1.5 SSL_CTX_set_client_CA_list.3 > --- SSL_CTX_set_client_CA_list.3 27 Mar 2018 17:35:50 -0000 1.5 > +++ SSL_CTX_set_client_CA_list.3 29 Mar 2020 20:18:28 -0000 > @@ -143,11 +143,6 @@ or > .Pp > These functions are only useful for TLS/SSL servers. > .Sh RETURN VALUES > -.Fn SSL_CTX_set_client_CA_list > -and > -.Fn SSL_set_client_CA_list > -do not return diagnostic information. > -.Pp > .Fn SSL_CTX_add_client_CA > and > .Fn SSL_add_client_CA > Index: SSL_CTX_set_quiet_shutdown.3 > =================================================================== > RCS file: /cvs/src/lib/libssl/man/SSL_CTX_set_quiet_shutdown.3,v > retrieving revision 1.5 > diff -u -p -r1.5 SSL_CTX_set_quiet_shutdown.3 > --- SSL_CTX_set_quiet_shutdown.3 8 Jun 2019 15:25:43 -0000 1.5 > +++ SSL_CTX_set_quiet_shutdown.3 29 Mar 2020 20:18:28 -0000 > @@ -144,11 +144,6 @@ This behaviour violates the TLS standard > .Pp > The default is normal shutdown behaviour as described by the TLS standard. > .Sh RETURN VALUES > -.Fn SSL_CTX_set_quiet_shutdown > -and > -.Fn SSL_set_quiet_shutdown > -do not return diagnostic information. > -.Pp > .Fn SSL_CTX_get_quiet_shutdown > and > .Fn SSL_get_quiet_shutdown > Index: SSL_CTX_set_tmp_dh_callback.3 > =================================================================== > RCS file: /cvs/src/lib/libssl/man/SSL_CTX_set_tmp_dh_callback.3,v > retrieving revision 1.7 > diff -u -p -r1.7 SSL_CTX_set_tmp_dh_callback.3 > --- SSL_CTX_set_tmp_dh_callback.3 27 Mar 2018 17:35:50 -0000 1.7 > +++ SSL_CTX_set_tmp_dh_callback.3 29 Mar 2020 20:18:29 -0000 > @@ -175,11 +175,6 @@ and > .Fa is_export > and simply supply at least 2048-bit parameters in the callback. > .Sh RETURN VALUES > -.Fn SSL_CTX_set_tmp_dh_callback > -and > -.Fn SSL_set_tmp_dh_callback > -do not return diagnostic output. > -.Pp > .Fn SSL_CTX_set_tmp_dh > and > .Fn SSL_set_tmp_dh > Index: SSL_free.3 > =================================================================== > RCS file: /cvs/src/lib/libssl/man/SSL_free.3,v > retrieving revision 1.4 > diff -u -p -r1.4 SSL_free.3 > --- SSL_free.3 27 Mar 2018 17:35:50 -0000 1.4 > +++ SSL_free.3 29 Mar 2020 20:18:29 -0000 > @@ -103,9 +103,6 @@ was not used to set the > .Vt SSL_SENT_SHUTDOWN > state, the session will also be removed from the session cache as required by > RFC2246. > -.Sh RETURN VALUES > -.Fn SSL_free > -does not provide diagnostic information. > .Sh SEE ALSO > .Xr ssl 3 , > .Xr SSL_clear 3 , > Index: SSL_set_shutdown.3 > =================================================================== > RCS file: /cvs/src/lib/libssl/man/SSL_set_shutdown.3,v > retrieving revision 1.4 > diff -u -p -r1.4 SSL_set_shutdown.3 > --- SSL_set_shutdown.3 27 Mar 2018 17:35:50 -0000 1.4 > +++ SSL_set_shutdown.3 29 Mar 2020 20:18:29 -0000 > @@ -122,9 +122,6 @@ or > .Fn SSL_set_shutdown > itself. > .Sh RETURN VALUES > -.Fn SSL_set_shutdown > -does not return diagnostic information. > -.Pp > .Fn SSL_get_shutdown > returns the current setting. > .Sh SEE ALSO
