On 31/03/20(Tue) 16:48, Vitaliy Makkoveev wrote: > I refactored pppx(4). The idea is to use pipex(4) as it was designed. > No one holds pipex_session outside pipex(4) so pipex_timer() calls are > safe. Unfortunately, this way gives some performance impact, because we > need to call pipex_lookup_by_session_id() in some places. This impact > will gone after pipex_session becames safely shared between multiple > holders and this is my next goal.
I'd be more confident if we could go with the one-line change that you submitted in the first mail of this thread without the debugging messages. Mixing bug-fixes (or features) and refactoring is not a great development practise as it might hide the point of the change and introduce or expose new bugs.
