Hi Ingo On Fri, Apr 03, 2020 at 01:55:56PM +0200, Ingo Schwarze wrote: > Hi Martin, > > Martin Vahlensieck wrote on Thu, Apr 02, 2020 at 10:57:04AM +0200: > > > I think these are superfluous. > > Correct, and it is irritating to have a general style of not using > argument names in prototypes in mandoc, but then a few scattered > names here and there, so i committed your patch. > Thanks for sending it. > > In the future, when sending patches, could you please restore your > last name to the From: header? I consider it disrespectful forcing > developers who want to commit your patches to waste time on the > extra, useless work of searching for your name. I meant no disrespect. Thanks for pointing it out. Fixed. > For an extremely simple, probably not Copyright-worthy patch like > this one, it may not matter much, but as soon as you send a patch > that (even potentially) might meet the threshold of originality > with respect to Copyright, it becomes important that the developer > committing the patch mentions the full real name of the person who > sent in the patch in the commit message, such that it is clear who > owns the Copyright on the changes and, by implication, who the > person is putting these changes under the license displayed at the > top of the file. > > Thanks, > Ingo >
Best, Martin
