On Tue, Apr 21, 2020 at 07:08:48AM +0000, [email protected] wrote: > April 21, 2020 4:28 AM, "Todd C. Miller" <[email protected]> wrote: > > > On Mon, 20 Apr 2020 15:01:31 +0200, Eric Faurot wrote: > > > >> There has been a discussion a while ago about the issue of trailing CR > >> in smtp lines (https://marc.info/?l=openbsd-tech&m=156890805128121&w=2). > >> > >> It is agreed that stripping an optional CR at io level is a problem > >> because the information is lost and there is no way to take a specific > >> action at the protocol level if needed. > >> > >> So this diffs moves the CR stripping from io level to protocol level for > >> SMTP dialogs. Other uses of io_getline() are internal and expect simple LF > >> line ending. The current behavior should not change. > > > > This looks OK to me but I would feel better if we had successful > > reports from other people too. > > > > Have been running with eric's diff since yesterday afternoon, works for me
No issue reported so far. I think it can go in. Eric.
