Hiltjo Posthuma([email protected]) on 2020.05.01 16:31:33 +0200: > On Fri, May 01, 2020 at 01:18:03PM +0200, Claudio Jeker wrote: > > This diff add JSON output support for bgpctl. > > Most commands should produce now a resonable JSON object. > > The individual objects can probably be improved and extended. > > I'm at a point where I'm happy with the result and looking for feedback. > > It is possible to commit the non-JSON bits first and add output-json.c > > once the output is enough stable. > > > > Hi, > > Maybe in the function do_name() and in functions where strings are printed the > text should be escaped just in case? For example the characters ", \ and > encoding of control-characters.
I think the only string thats not generated from trusted data (i.e. hardcoded strings, strings fromthe configuration file or numbers) is escaped with strnvis() in log_shutcomm().
