On Thu, May 14, 2020 at 04:10:42PM +0200, Denis Fondras wrote:
> IMSG_IFADD is never used, wipe it.
In ospfd we have IMSG_RECONF_IFACE for this. Once we start adding
reload functionality we can bring that over to ospf6d.
OK remi@
>
> Index: ospf6d.h
> ===================================================================
> RCS file: /cvs/src/usr.sbin/ospf6d/ospf6d.h,v
> retrieving revision 1.46
> diff -u -p -r1.46 ospf6d.h
> --- ospf6d.h 5 Apr 2020 18:19:04 -0000 1.46
> +++ ospf6d.h 14 May 2020 13:52:08 -0000
> @@ -103,7 +103,6 @@ enum imsg_type {
> IMSG_KROUTE_CHANGE,
> IMSG_KROUTE_DELETE,
> IMSG_IFINFO,
> - IMSG_IFADD,
> IMSG_IFDELETE,
> IMSG_IFADDRNEW,
> IMSG_IFADDRDEL,
> Index: ospfe.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/ospf6d/ospfe.c,v
> retrieving revision 1.61
> diff -u -p -r1.61 ospfe.c
> --- ospfe.c 2 Jan 2020 10:16:46 -0000 1.61
> +++ ospfe.c 14 May 2020 13:52:08 -0000
> @@ -327,18 +327,6 @@ ospfe_dispatch_main(int fd, short event,
> log_warnx("interface %s down", iface->name);
> }
> break;
> - case IMSG_IFADD:
> - if ((iface = malloc(sizeof(struct iface))) == NULL)
> - fatal(NULL);
> - memcpy(iface, imsg.data, sizeof(struct iface));
> -
> - LIST_INIT(&iface->nbr_list);
> - TAILQ_INIT(&iface->ls_ack_list);
> - RB_INIT(&iface->lsa_tree);
> -
> - LIST_INSERT_HEAD(&iface->area->iface_list, iface,
> - entry);
> - break;
> case IMSG_IFDELETE:
> if (imsg.hdr.len != IMSG_HEADER_SIZE +
> sizeof(ifindex))
> Index: rde.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/ospf6d/rde.c,v
> retrieving revision 1.86
> diff -u -p -r1.86 rde.c
> --- rde.c 5 Apr 2020 18:19:04 -0000 1.86
> +++ rde.c 14 May 2020 13:52:09 -0000
> @@ -734,17 +734,6 @@ rde_dispatch_parent(int fd, short event,
> orig_intra_area_prefix_lsas(iface->area);
>
> break;
> - case IMSG_IFADD:
> - if ((iface = malloc(sizeof(struct iface))) == NULL)
> - fatal(NULL);
> - memcpy(iface, imsg.data, sizeof(struct iface));
> -
> - LIST_INIT(&iface->nbr_list);
> - TAILQ_INIT(&iface->ls_ack_list);
> - RB_INIT(&iface->lsa_tree);
> -
> - LIST_INSERT_HEAD(&iface->area->iface_list, iface,
> entry);
> - break;
> case IMSG_IFDELETE:
> if (imsg.hdr.len != IMSG_HEADER_SIZE +
> sizeof(ifindex))
>
