The <syslog.h> header contains an outdated comment about
headers <machine/stdarg.h> and <machine/varargs.h> and should
be updated.
The comment is not fully consistent with the syslog(3) manual page
because the manual does mention <stdarg.h>. However, the header's
point still seems valid.
OK?
Index: sys/syslog.h
===================================================================
RCS file: src/sys/sys/syslog.h,v
retrieving revision 1.16
diff -u -p -r1.16 syslog.h
--- sys/syslog.h 8 Aug 2017 14:23:23 -0000 1.16
+++ sys/syslog.h 20 May 2020 16:11:59 -0000
@@ -183,11 +183,10 @@ struct syslog_data {
#ifndef _KERNEL
/*
- * Don't use va_list in the vsyslog() prototype. Va_list is typedef'd in two
- * places (<machine/varargs.h> and <machine/stdarg.h>), so if we include one
- * of them here we may collide with the utility's includes. It's unreasonable
- * for utilities to have to include one of them to include syslog.h, so we get
- * __va_list from <machine/_types.h> and use it.
+ * Don't use va_list in the vsyslog() prototype. Va_list is typedef'd
+ * in <stdarg.h>. Including it here may collide with the utility's includes.
+ * It's unreasonable for utilities to have to include it to include <syslog.h>,
+ * so we get __va_list from <machine/_types.h> and use it.
*/
#include <sys/cdefs.h>
#include <machine/_types.h>
