On 30/05/20(Sat) 09:25, Theo de Raadt wrote:
> [...] 
> What does this have to do with threads?  That is an implimentation detail.

This implementation detail is specific to NFS, no other FS do anything
like that.  So I'm questioning whether calling kthread_create(9) inside a
kqueue(2) handler, which is called from kevent(2) and could be called
from poll(2) is the wanted behavior.

> This is about behaviour.  If you open a FFS directory, do you eventually
> get updates?

FFS and all the other FS have the same behavior when it comes to poll(2)
and kqueue(2).  They don't check for I/O and return true.  NFS tries to
be clever for kqueue(2)-only, I'm questioning the added value of that
cleverness.

> Should NFS not try to act the same?

That's exactly what my diff is doing: bring it in sync with other FS.

Reply via email to