Mark Kettenis <[email protected]> wrote:

> > Date: Tue, 9 Jun 2020 23:43:50 +0200
> > From: Christian Weisgerber <[email protected]>
> > 
> > Mark Kettenis:
> > 
> > > Unfortunately that doesn't quite work.  At least in my build it
> > > doesn't pick up .c files in the linker/arch directories.
> > > 
> > > > Index: lib/libkern/arch/arm64/ffs.c
> > 
> > I was certain I had checked this, but indeed it doesn't work.
> > 
> > The Makefile rules are generated from sys/conf/files:
> > 
> > ...
> > file lib/libkern/arch/${MACHINE_ARCH}/ffs.S | lib/libkern/ffs.c
> > ...
> > 
> > We could extend this by a third file.  Ugly.
> > Alternatively I could go back to .S, sigh.
> 
> FWIW, .S would be perfectly fine with me.  This is writeonce, forget
> forevere code so maintaining .S files isn't a huge burden.

I agree.

The important thing that would do is keep the build/infrastructure
frameworks simpler.  Overcomplicating those risks "oh but which file
first" types of issues which always burn me first.

Reply via email to