> Date: Thu, 11 Jun 2020 11:42:23 +0200 > From: Stefan Sperling <[email protected]> > > On Thu, Jun 11, 2020 at 11:00:30AM +0200, Mark Kettenis wrote: > > > Date: Thu, 11 Jun 2020 10:48:09 +0200 > > > From: Stefan Sperling <[email protected]> > > > > > > I spotted this while working on iwx(4). > > > > > > Setting up ic_myaddr when we're about to scan for APs is rather late in > > > the game. All these drivers are already setting up ic_myaddr during the > > > device initialization phase, long before they get here. > > > > > > This seems to be a copy-paste error in iwn(4) originally. > > > The older wpi(4) driver has similar code which doesn't have this. > > > > > > ok? > > > > Hmm, won't this affect the ability to changed the lladdr while the > > interface is up? > > That was never possible. > Changing LLADDR implies ENETRESET, i.e. a down -> up cycle.
Ah, that's done by calling ifnewlladdr() after the ioctl is completed. With that cleared up; ok kettenis@
