On Mon, Jun 22, 2020 at 05:49:43AM +0200, Klemens Nanni wrote:
> The manual's wording is untouched since import in 1995, engine.c however
> came to be in 2008 as "New display engine for systat" from canacar.
> 
> While characte erase (^h) works, word erase (^w) is not implemented and
> line kill (^u) is supported but as ^g instead.
> 
> I see no value in documenting this either way, so remove the lines from
> the manual but also support the actual line kill character for.
> 
> Feedback? OK?
> 

morning.

how will people be able to find this if we don;t document it? from a
brief skim of docs which may hold answers, i still can;t find where
these values are documented.

couldn;t we document these work and what the defaults are? it seems
handy.

jmc

> 
> Index: engine.c
> ===================================================================
> RCS file: /cvs/src/usr.bin/systat/engine.c,v
> retrieving revision 1.25
> diff -u -p -r1.25 engine.c
> --- engine.c  12 Jan 2020 20:51:08 -0000      1.25
> +++ engine.c  22 Jun 2020 03:35:40 -0000
> @@ -1204,6 +1204,7 @@ cmd_keyboard(int ch)
>               break;
>       case 0x1b:
>       case CTRL_G:
> +     case CTRL_U:
>               if (cmd_len > 0) {
>                       cmdbuf[0] = '\0';
>                       cmd_len = 0;
> Index: engine.h
> ===================================================================
> RCS file: /cvs/src/usr.bin/systat/engine.h,v
> retrieving revision 1.12
> diff -u -p -r1.12 engine.h
> --- engine.h  12 Jan 2020 20:51:08 -0000      1.12
> +++ engine.h  22 Jun 2020 03:36:21 -0000
> @@ -36,6 +36,7 @@
>  #define CTRL_L  12
>  #define CTRL_N  14
>  #define CTRL_P  16
> +#define CTRL_U  21
>  #define CTRL_V  22
>  
>  #define META_V  246
> Index: systat.1
> ===================================================================
> RCS file: /cvs/src/usr.bin/systat/systat.1,v
> retrieving revision 1.117
> diff -u -p -r1.117 systat.1
> --- systat.1  23 Apr 2020 07:57:27 -0000      1.117
> +++ systat.1  22 Jun 2020 03:09:25 -0000
> @@ -172,9 +172,6 @@ These are:
>  .It Ic \&:
>  Move the cursor to the command line and interpret the input
>  line typed as a command.
> -While entering a command the
> -current character erase, word erase, and line kill characters
> -may be used.
>  .It Ic o
>  Select the next ordering which sorts the rows according to a
>  combination of columns.
> 

Reply via email to