On Sun, Jul 12, 2020 at 10:31:49PM +0300, Vitaliy Makkoveev wrote:
> I like to have "sizeof(*omi)" in corresponding malloc(9) too.
>
> ---- cut begin ----
> 827 omi = malloc(sizeof(struct sr_meta_opt_item), M_DEVBUF,
> 828 M_WAITOK | M_ZERO);
> ---- cut end ----
If you prefer to have malloc() and free() use the same idiom, I can
commit the diff below, otherwise I'd refrain from changing existing code
for this alone to avoid churn.
Feedback? OK?
Index: dev/softraid_crypto.c
===================================================================
RCS file: /cvs/src/sys/dev/softraid_crypto.c,v
retrieving revision 1.138
diff -u -p -r1.138 softraid_crypto.c
--- dev/softraid_crypto.c 4 Jul 2019 18:09:17 -0000 1.138
+++ dev/softraid_crypto.c 12 Jul 2020 22:21:09 -0000
@@ -882,7 +882,7 @@ done:
for (omi = SLIST_FIRST(&som); omi != NULL; omi = omi_next) {
omi_next = SLIST_NEXT(omi, omi_link);
free(omi->omi_som, M_DEVBUF, 0);
- free(omi, M_DEVBUF, 0);
+ free(omi, M_DEVBUF, sizeof(struct sr_meta_opt_item));
}
free(sm, M_DEVBUF, SR_META_SIZE * DEV_BSIZE);
