Schreilechner, Dominik (2020-07-30 11:35 +0000): > > From: Jason McIntyre, Mittwoch, 29. Juli 2020 14:23 > > > > On Wed, Jul 29, 2020 at 11:37:03AM +0000, Schreilechner, Dominik wrote: > > > Hi, > > > > > > I noticed, that the description of vgone/vgonel in the manpage does not > > > match the \ > > > code. The manpage (https://man.openbsd.org/vgone) states: > > > The difference between vgone() and vgonel() is that vgone() locks the > > > vnode \ > > > interlock and then calls vgonel() while vgonel() expects the interlock to > > > already \ > > > be locked. > > > However, vgone simply calls vgonel with curproc (see vfs_subr.c). > > > void > > > vgone(struct vnode *vp) > > > { > > > struct proc *p = curproc; > > > vgonel(vp, p); > > > } > > > > > > Best regards, > > > Dominik > > > > > > > hi. > > > > it would be easier to get things improved if you attached a diff > > describing what you think is correct. even failing a diff, a piece of > > text saying what you think it should be would increase your chances. > > > > jmc > > Sorry, I was not sure about that, but worst case I am wrong, I guess. > Below is a diff of the man page, that describes the current difference > between vgone and vgonel as it is in the code.
We ended up committing a somewhat different diff. Thank you for reporting!
