ok
Ross L Richardson([email protected]) on 2020.08.02 21:52:50 +1000:
> cppcheck finds an unnecessary assignment.
>
> The patch below deletes it.
>
> Ross
>
> Index: server_fcgi.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/httpd/server_fcgi.c,v
> retrieving revision 1.81
> diff -u -p -r1.81 server_fcgi.c
> --- server_fcgi.c 9 Feb 2020 09:44:04 -0000 1.81
> +++ server_fcgi.c 2 Aug 2020 11:49:44 -0000
> @@ -684,7 +684,7 @@ server_fcgi_header(struct client *clt, u
>
> /* Date header is mandatory and should be added as late as possible */
> key.kv_key = "Date";
> - if ((kv = kv_find(&resp->http_headers, &key)) == NULL &&
> + if (kv_find(&resp->http_headers, &key) == NULL &&
> (server_http_time(time(NULL), tmbuf, sizeof(tmbuf)) <= 0 ||
> kv_add(&resp->http_headers, "Date", tmbuf) == NULL))
> return (-1);
>
