On Wed, Sep 02, 2020 at 04:12:33PM +1000, Matt Dunwoodie wrote:
> The patch isn't fully correct. When you remove a peer, sc_peer_num
> will decrement, and if you add a new peer afterwards you will have
> duplicate IDs. This is likely to create further headaches. A dedicated
> ID counter in wg_softc should probably be used.
Yes, it's just a small improvement and removing individual peers brings
counting out of sync, although I'd argue its still more useful than the
global counter.

I can give proper peer counting a try soon.

Reply via email to