On Sat, Sep 12, 2020 at 08:13:43PM +0300, Peter Pentchev wrote: > On Sat, Sep 12, 2020 at 06:58:30PM +0200, Florian Obser wrote: > > On Sat, Sep 12, 2020 at 05:15:08PM +0200, Klemens Nanni wrote: > > > On Sat, Sep 12, 2020 at 05:11:00PM +0200, Klemens Nanni wrote: > > > > Bit hard to read, what about aligning like this? > > > > > > > > + if ((rdns_proposal->src == 0 || > > > > + rdns_proposal->src == tmp->src) && > > > > + (rdns_proposal->if_index == 0 || > > > > + rdns_proposal->if_index == tmp->if_index)) > > > With a space here ^ > > > > > > > I'd rather not, style(9): > > Indentation is an 8 character tab. Second level indents are four > > spaces. > > > > Also, my editor would fix it up the next time I touch those lines. > > Er... so what's the difference with the second line, two lines above > that? "rdns_proposal->src == tmp->src" seems to have that space.
sure, because kn added it, have a look at the original diff, it's formated completely different. > > G'luck, > Peter > > -- > Peter Pentchev [email protected] [email protected] [email protected] > PGP key: http://people.FreeBSD.org/~roam/roam.key.asc > Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13 -- I'm not entirely sure you are real.
