On Wed, Oct 21, 2020 at 07:32:46PM -0400, Ashton Fagg wrote: > Jonathan Gray <j...@jsg.id.au> writes: > > > pcidevs.h is a generated file. After pcidevs is modified 'make' is run > > in sys/dev/pci then pcidevs.h and pcidevs_data.h are created based on > > that. In this case it is already there though so you don't need to > > change it. > > Thanks for the review. Updated patch attached. I've rebuilt and tested > it to ensure it works. >
0x1637 / 'Renoir HD Audio' is what would be used for HDMI audio if that were handled. audio(4) only attaches to the azalia device with a product id of 0x15e3 / '17h/1xh HD Audio' > azalia0 at pci6 dev 0 function 1 "ATI Renoir HD Audio" rev 0x00: msi > azalia0: no supported codecs > azalia1 at pci6 dev 0 function 6 "AMD 17h/1xh HD Audio" rev 0x00: apic 33 int > 12 > azalia1: codecs: Realtek ALC257 > audio0 at azalia1 I'd go with the below adding the beep quirk if it makes an audible difference hitting backspace in a vt. Index: sys/dev/pci/azalia.c =================================================================== RCS file: /cvs/src/sys/dev/pci/azalia.c,v retrieving revision 1.257 diff -u -p -r1.257 azalia.c --- sys/dev/pci/azalia.c 9 Jun 2020 03:36:05 -0000 1.257 +++ sys/dev/pci/azalia.c 22 Oct 2020 02:05:39 -0000 @@ -386,6 +386,9 @@ azalia_configure_pci(azalia_t *az) switch (PCI_PRODUCT(az->pciid)) { case PCI_PRODUCT_ATI_SB450_HDA: case PCI_PRODUCT_ATI_SBX00_HDA: + case PCI_PRODUCT_AMD_15_6X_AUDIO: + case PCI_PRODUCT_AMD_17_HDA: + case PCI_PRODUCT_AMD_17_1X_HDA: case PCI_PRODUCT_AMD_HUDSON2_HDA: reg = azalia_pci_read(az->pc, az->tag, ATI_PCIE_SNOOP_REG); reg &= ATI_PCIE_SNOOP_MASK; Index: sys/dev/pci/azalia_codec.c =================================================================== RCS file: /cvs/src/sys/dev/pci/azalia_codec.c,v retrieving revision 1.178 diff -u -p -r1.178 azalia_codec.c --- sys/dev/pci/azalia_codec.c 14 Oct 2019 02:04:35 -0000 1.178 +++ sys/dev/pci/azalia_codec.c 18 Oct 2020 08:00:10 -0000 @@ -83,6 +83,9 @@ azalia_codec_init_vtbl(codec_t *this) this->name = "Realtek ALC221"; this->qrks |= AZ_QRK_WID_CDIN_1C | AZ_QRK_WID_BEEP_1D; break; + case 0x10ec0257: + this->name = "Realtek ALC257"; + break; case 0x10ec0260: this->name = "Realtek ALC260"; if (this->subid == 0x008f1025)