On Thu, Oct 22, 2020 at 04:34:11PM +0200, Robert Nagy wrote:
> The diff below makes azalia(4) work on my new shiny chromium build box:

You have a 17-31-00 epyc or threadripper?

This id also shows up on
B550, Ryzen 9 3900X 17-71-00
X570, Ryzen 5 3600 17-71-00

The other two 17h/3xh ids also show up on 17-71-00 machines.

It seems they are shared between 17-3x epyc/threadripper and
17-7x ryzen.  I am not aware of any public documents from AMD which
list these devices.

It is surprising your diff would change anything more than dmesg
text.

> 
> Index: dev/pci/azalia_codec.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/pci/azalia_codec.c,v
> retrieving revision 1.178
> diff -u -p -u -r1.178 azalia_codec.c
> --- dev/pci/azalia_codec.c      14 Oct 2019 02:04:35 -0000      1.178
> +++ dev/pci/azalia_codec.c      22 Oct 2020 14:32:55 -0000
> @@ -222,6 +222,10 @@ azalia_codec_init_vtbl(codec_t *this)
>                     this->subid == 0x00a0106b)
>                         this->qrks |= AZ_QRK_WID_OVREF50;
>                 break;
> +       case 0x10ec0887:
> +               this->name = "Realtek ALC887";
> +               this->qrks |= AZ_QRK_WID_CDIN_1C | AZ_QRK_WID_BEEP_1D;
> +               break;
>         case 0x10ec0888:
>                 this->name = "Realtek ALC888";
>                 this->qrks |= AZ_QRK_WID_CDIN_1C | AZ_QRK_WID_BEEP_1D;
> Index: dev/pci/pcidevs
> ===================================================================
> RCS file: /cvs/src/sys/dev/pci/pcidevs,v
> retrieving revision 1.1939
> diff -u -p -u -r1.1939 pcidevs
> --- dev/pci/pcidevs     7 Oct 2020 11:14:59 -0000       1.1939
> +++ dev/pci/pcidevs     22 Oct 2020 14:32:56 -0000
> @@ -751,6 +751,7 @@ product AMD 17_PCIE_4               0x1470  17h PCIE
>  product AMD 17_PCIE_5          0x1471  17h PCIE
>  product AMD 17_3X_RC           0x1480  17h/3xh Root Complex
>  product AMD 17_3X_CCP          0x1486  17h/3xh Crypto
> +product AMD 17_3X_HDA          0x1487  17h/3xh HD Audio
>  product AMD 14_HB              0x1510  14h Host
>  product AMD 14_PCIE_1          0x1512  14h PCIE
>  product AMD 14_PCIE_2          0x1513  14h PCIE
> Index: dev/pci/pcidevs.h
> ===================================================================
> RCS file: /cvs/src/sys/dev/pci/pcidevs.h,v
> retrieving revision 1.1932
> diff -u -p -u -r1.1932 pcidevs.h
> --- dev/pci/pcidevs.h   7 Oct 2020 11:15:31 -0000       1.1932
> +++ dev/pci/pcidevs.h   22 Oct 2020 14:32:58 -0000
> @@ -756,6 +756,7 @@
>  #define        PCI_PRODUCT_AMD_17_PCIE_5       0x1471          /* 17h PCIE */
>  #define        PCI_PRODUCT_AMD_17_3X_RC        0x1480          /* 17h/3xh 
> Root Complex */
>  #define        PCI_PRODUCT_AMD_17_3X_CCP       0x1486          /* 17h/3xh 
> Crypto */
> +#define        PCI_PRODUCT_AMD_17_3X_HDA       0x1487          /* 17h/3xh HD 
> Audio */
>  #define        PCI_PRODUCT_AMD_14_HB   0x1510          /* 14h Host */
>  #define        PCI_PRODUCT_AMD_14_PCIE_1       0x1512          /* 14h PCIE */
>  #define        PCI_PRODUCT_AMD_14_PCIE_2       0x1513          /* 14h PCIE */
> Index: dev/pci/pcidevs_data.h
> ===================================================================
> RCS file: /cvs/src/sys/dev/pci/pcidevs_data.h,v
> retrieving revision 1.1927
> diff -u -p -u -r1.1927 pcidevs_data.h
> --- dev/pci/pcidevs_data.h      7 Oct 2020 11:15:31 -0000       1.1927
> +++ dev/pci/pcidevs_data.h      22 Oct 2020 14:32:59 -0000
> @@ -1328,6 +1328,10 @@ static const struct pci_known_product pc
>             "17h/3xh Crypto",
>         },
>         {
> +           PCI_VENDOR_AMD, PCI_PRODUCT_AMD_17_3X_HDA,
> +           "17h/3xh HD Audio",
> +       },
> +       {
>             PCI_VENDOR_AMD, PCI_PRODUCT_AMD_14_HB,
>             "14h Host",
>         },
> 
> 

Reply via email to