Enabling for all Realtek codecs sounds like a good idea to me. I was overcautious when applying it to only my vendor/product ID.
On 18/11/2020 03:50, Jonathan Gray wrote: > On Wed, Nov 18, 2020 at 01:41:49AM +0000, Sine Astris wrote: >> Hi, >> >> I wasn't able to adjust the volume of the keyboard bell via >> wsconsctl(8), or the volume of /dev/speaker on my ThinkPad X270. >> >> Additionally, the default spkr_source (mix3) doesn't output the beep. >> Changing to mix2, sounds the beep and my existing audio seems fine. >> >> # mixerctl outputs.spkr_source=mix2 >> >> I applied the AZ_QRK_WID_BEEP_1D quirk to the Realtek ALC298 codec for >> my devices vendor/product ID, and this seems to have resolved the issue. >> Keyboard bell and /dev/speaker volume adjusts via wsconsctl(8) / >> mixerctl(8)'s inputs.mix_beep=x,x >> >> Below are diff to azalia_codec.c, pcidump for my audio device, final >> mixerctl output, and dmesg. > > There is no cd audio input so I don't see a need for that quirk. > > I see no reason to limit enabling beep as it will be in the same > place for everything with that codec. Perhaps we should just > enable it for all Realtek codecs. > > Index: azalia_codec.c > =================================================================== > RCS file: /cvs/src/sys/dev/pci/azalia_codec.c,v > retrieving revision 1.182 > diff -u -p -r1.182 azalia_codec.c > --- azalia_codec.c 25 Oct 2020 02:54:38 -0000 1.182 > +++ azalia_codec.c 18 Nov 2020 03:43:10 -0000 > @@ -208,6 +208,7 @@ azalia_codec_init_vtbl(codec_t *this) > this->name = "Realtek ALC295"; > break; > case 0x10ec0298: > + this->qrks |= AZ_QRK_WID_BEEP_1D; > this->name = "Realtek ALC298"; > if (this->subid == 0x320019e5 || > this->subid == 0x320119e5) /* Huawei Matebook X */ >
OpenPGP_0x4383C362B5F65EF4.asc
Description: application/pgp-keys
OpenPGP_signature
Description: OpenPGP digital signature
