I agree but I thought this should be done in a second time as it is quite invasive and not required for the change to be visible outside the daemon
December 19, 2020 11:13 PM, "Martijn van Duren" <openbsd+t...@list.imperialat.at> wrote: > I'm in favour of this change, since I like proper nomenclature. > But I think you should push this one to its logical conclusion and also > rename the enum and potential other pony/klondike references, because > with your diff the naming is inconsistent, which is even more confusing. > > martijn@ > > On Sat, 2020-12-19 at 22:06 +0000, gil...@poolp.org wrote: > >> Hello, >> >> A very long time ago, smtpd had several more processes which then got >> factored >> into a single one. We couldn't find a decent name back then but since a >> hacker >> had requested a pony from me I temporarily named the process "pony express" >> as >> it was in charge of delivering mail. Later, reyk improved the joke as he >> named >> the privsep crypto process klondike. >> >> A few years ago when the config was reworked, we used the term "dispatcher" >> to >> identify if a mail was dispatched to the mda or mta layer. >> >> Unless someone is very emotionally attached to the initial joke, I suggest >> the >> pony express process be renamed to dispatcher and klondike to crypto. The >> goal >> is not just to end the joke but also to avoid a process name with a space, >> and >> also because it makes it less obvious what these processes do. >> >> diff --git a/usr.sbin/smtpd/smtpd.c b/usr.sbin/smtpd/smtpd.c >> index 854c2ab0cb6..b364b22e472 100644 >> --- a/usr.sbin/smtpd/smtpd.c >> +++ b/usr.sbin/smtpd/smtpd.c >> @@ -1913,9 +1913,9 @@ proc_title(enum smtp_proc_type proc) >> case PROC_SCHEDULER: >> return "scheduler"; >> case PROC_PONY: >> - return "pony express"; >> + return "dispatcher"; >> case PROC_CA: >> - return "klondike"; >> + return "crypto"; >> case PROC_CLIENT: >> return "client"; >> case PROC_PROCESSOR:
