Am Wed, Dec 23, 2020 at 11:32:58PM +0100 schrieb Frederic Cambus: > Hi Mark, > > On Fri, Dec 18, 2020 at 10:33:52PM +0100, Mark Kettenis wrote: > > > The diff below disables the optimized functions on little-endian > > architectures such that we always use rasops1_putchar(). This makes > > ssdfb(4) work with the default 8x16 font on arm64. > > I noticed it was committed already, but it seems the following > directives: > > #if defined(RASOPS_SMALL) && BYTE_ORDER == BIG_ENDIAN > > Should have been: > > #if !defined(RASOPS_SMALL) && BYTE_ORDER == BIG_ENDIAN > > We want to include the optimized putchar functions only if RASOPS_SMALL > is not defined. >
True that. In one #endif comment he actually kept the !, but the actual ifs lost it.
