Hi Marcus,

* Marcus Glocker wrote:
> Thanks for testing Laurie.
> 
> Otherwise I got not much feedback -- No interest in this?

Yes, sure.  I really like the feature since it offers an additional
level of privacy when /dev/video* is not owned by root and is a
perfect supplement to kern.audio.recording.

> What I like about the approach are mainly two things:
> 
> 1. We're aligning to audio(4), which has the kern.audio.record toggle
>    already in place.  If we have a toggle for audio recording, why not
>    having one for video recording?
> 
> 2. If we would decide to get kern.video.record in, as a next step I
>    would like to propose changing the /dev/video* permissions so we
>    don't require root access to execute video programs, by adding a
>    new group 'video' and apply it together with 660 permissions to
>    /dev/video*.  By that we require initial root access to enable
>    video recording, but can then permit non-root accounts for video
>    access.

I tested your patch with the following setup and it worked as expected.
When set to 0 I only saw a complete green video feed, when set to 1 I got
the camera picture as usual.

* video(1) worked
* Chrome and Firefox showed the camera feed and toggling worked
* I participated in a Google Meet session via Chrome and could toogle
  the sysctl and my camera feed switched from green to live.

I tested with a Thinkpad X250 and the integrated webcam:

uvideo0 at uhub0 port 8 configuration 1 interface 0 "Chicony Electronics
Co.,Ltd. Integrated Camera" rev 2.00/0.24 addr 4
video0 at uvideo0

Cheers and thanks for your work

        Matthias

Reply via email to