On 15/01/21 14:53 +0100, Claudio Jeker wrote: > I forgot to add ip_mreqn support to IP_MULTICAST_IF and so the > IP_ADD_MEMBERSHIP change is not fixing all the issues I have. > > Linux supports calling IP_MULTICAST_IF with a struct in_addr, a struct > ip_mreq, or a struct ip_mreqn. FreeBSD only does the first and last. > I followed the Linux way because doing that was not that hard. In the end > only the imr_ifindex field and the imr_address field need to be checked > and if the imr_ifindex is 0 then just use the old code. If the imr_ifindex > is set then use this for interface index and break early. > > Any opinions about this?
Following the linux way is the way to go because most of the 3rd party software will expect that. As I said already, this fixed an issue in chromium already, so I am okay with it.