On Wed, Feb 03, 2021 at 10:20:47PM +0100, Theo Buehler wrote:
> On Wed, Feb 03, 2021 at 08:08:20PM +0100, Claudio Jeker wrote:
> > This is just shuffling code around and adds a few definitions to extern.h.
> > The goal is to reduce the amount of code in main.c. I constantly get lost
> > in all the parsing and parent functions also I want to extend the
> > repository code and so this makes space for that.
> > 
> > Compiles and works for me :)
> 
> ok tb
> 
> I think you can garbage collect all openssl includes in main.c.
> <sys/stat.h> and <fcntl.h> also seem unused.

<sys/stat.h> is needed for fts_open(3) according to the man page.
I did remove <fcntl.h> and added <errno.h>.
 
> In parser.c I would add openssl/asn1.h (e.g. for the sk_ business) and
> use x509.h instead of x509v3.h.

Done, I also remove evp.h since there is no EVP usage in parse.c 

-- 
:wq Claudio

Reply via email to